[PATCH] ARM: dts: at91: sama5d2 Xplained: Correct the macb irq pinctrl node
Ludovic Desroches
ludovic.desroches at atmel.com
Fri Feb 19 05:19:45 PST 2016
On Thu, Feb 18, 2016 at 11:21:06AM +0100, Romain Izard wrote:
> All pinctrl nodes for the Atmel pinctrl controller need to have their
> bias configuration explicitly defined. Otherwise, the pinctrl mapping
> is not valid.
>
> It works for now as the pinctrl driver proceeds even with invalid
> mappings, but this can become an issue, if the pinctrl driver starts
> to require valid mappings. Additionally, the pin is not protected from
> being remapped later by an other driver.
>
> There is an external 1kΩ pull-up to 3.3V, so no bias is required on
> the Ethernet PHY's interrupt line.
>
> Signed-off-by: Romain Izard <romain.izard.pro at gmail.com>
Acked-by: Ludovic Desroches <ludovic.desroches at atmel.com>
Thanks
> ---
> arch/arm/boot/dts/at91-sama5d2_xplained.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> index e683856c507c..75341eec2dfd 100644
> --- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> +++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> @@ -308,6 +308,7 @@
>
> pinctrl_macb0_phy_irq: macb0_phy_irq {
> pinmux = <PIN_PC9__GPIO>;
> + bias-disable;
> };
>
> pinctrl_pdmic_default: pdmic_default {
> --
> 2.5.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
More information about the linux-arm-kernel
mailing list