[PATCH v2 2/2] ARM64: dts: add LS1043a-QDS board support
Zhiqiang Hou
zhiqiang.hou at nxp.com
Fri Feb 19 02:10:04 PST 2016
Hi Shawn,
Thanks for your comments!
> -----Original Message-----
> From: Shawn Guo [mailto:shawnguo at kernel.org]
> Sent: 2016年2月19日 11:29
> To: Zhiqiang Hou <Zhiqiang.Hou at freescale.com>
> Cc: devicetree at vger.kernel.org; robh+dt at kernel.org; mark.rutland at arm.com;
> pawel.moll at arm.com; ijc+devicetree at hellion.org.uk; galak at codeaurora.org;
> linux-arm-kernel at lists.infradead.org; catalin.marinas at arm.com;
> will.deacon at arm.com; scottwood at freescale.com; Mingkai.Hu at freescale.com;
> Shaohui.Xie at freescale.com
> Subject: Re: [PATCH v2 2/2] ARM64: dts: add LS1043a-QDS board support
>
> On Thu, Dec 24, 2015 at 05:11:38PM +0800, Zhiqiang Hou wrote:
> > From: Shaohui Xie <Shaohui.Xie at freescale.com>
> >
>
> Empty commit log is generally not welcomed. You can have something here to
> introduce the board briefly.
>
Will add the introduce in v3.
> We generally use lowercase for arm64 patch subject prefix, i.e.
> "arm64: dts: ...". Yes, this is different from ARM.
Yes, will fix in v3.
> > Signed-off-by: Shaohui Xie <Shaohui.Xie at freescale.com>
> > Signed-off-by: Mingkai Hu <Mingkai.Hu at freescale.com>
> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou at freescale.com>
> > ---
> > v2:
> > - add root node compatible property
> >
> > arch/arm64/boot/dts/freescale/Makefile | 1 +
> > arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts | 168
> > ++++++++++++++++++++++
> > 2 files changed, 169 insertions(+)
> > create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> >
> > diff --git a/arch/arm64/boot/dts/freescale/Makefile
> > b/arch/arm64/boot/dts/freescale/Makefile
> > index f3c2516..1423fa4 100644
> > --- a/arch/arm64/boot/dts/freescale/Makefile
> > +++ b/arch/arm64/boot/dts/freescale/Makefile
> > @@ -2,6 +2,7 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-qds.dtb
> > dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-rdb.dtb
> > dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-simu.dtb
> > dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1043a-rdb.dtb
> > +dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1043a-qds.dtb
>
> The list should be sorted alphabetically. But it's not your fault, as fsl-ls1043a-
> rdb.dtb is already wrong.
>
> >
> > always := $(dtb-y)
> > subdir-y := $(dts-dirs)
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> > b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> > new file mode 100644
> > index 0000000..d7aae69
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> > @@ -0,0 +1,168 @@
> > +/*
> > + * Device Tree Include file for Freescale Layerscape-1043A family SoC.
> > + *
> > + * Copyright 2014-2015, Freescale Semiconductor
> > + *
> > + * Mingkai Hu <Mingkai.hu at freescale.com>
> > + *
> > + * This file is dual-licensed: you can use it either under the terms
> > + * of the GPLv2 or the X11 license, at your option. Note that this
> > +dual
> > + * licensing only applies to this file, and not this project as a
> > + * whole.
> > + *
> > + * a) This library is free software; you can redistribute it and/or
> > + * modify it under the terms of the GNU General Public License as
> > + * published by the Free Software Foundation; either version 2 of the
> > + * License, or (at your option) any later version.
> > + *
> > + * This library is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > + * GNU General Public License for more details.
> > + *
> > + * Or, alternatively,
> > + *
> > + * b) Permission is hereby granted, free of charge, to any person
> > + * obtaining a copy of this software and associated documentation
> > + * files (the "Software"), to deal in the Software without
> > + * restriction, including without limitation the rights to use,
> > + * copy, modify, merge, publish, distribute, sublicense, and/or
> > + * sell copies of the Software, and to permit persons to whom the
> > + * Software is furnished to do so, subject to the following
> > + * conditions:
> > + *
> > + * The above copyright notice and this permission notice shall be
> > + * included in all copies or substantial portions of the Software.
> > + *
> > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> > + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> > + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> > + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> > + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> > + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> > + * OTHER DEALINGS IN THE SOFTWARE.
> > + */
> > +
> > +/dts-v1/;
> > +/include/ "fsl-ls1043a.dtsi"
> > +
> > +/ {
> > + model = "LS1043A QDS Board";
> > + compatible = "fsl,ls1043a-qds", "fsl,ls1043a";
> > +
> > + aliases {
> > + serial0 = &lpuart0;
> > + serial1 = &lpuart1;
> > + serial2 = &lpuart2;
> > + serial3 = &lpuart3;
> > + serial4 = &lpuart4;
> > + serial5 = &lpuart5;
> > +
>
> This new line is not really necessary.
>
> > + gpio0 = &gpio1;
> > + gpio1 = &gpio2;
> > + gpio2 = &gpio3;
> > + gpio3 = &gpio4;
>
> I suggest to sort all these aliases entries alphabetically.
>
Yes, this will be arranged in v3.
> > + };
> > +};
> > +
> > +&i2c0 {
> > + status = "okay";
>
> I suggest to have a new line between properties and sub-node.
>
Yes, will add a new line here.
> > + pca9547 at 77 {
> > + compatible = "philips,pca9547";
>
> I cannot find this compatible string in either binding docs or driver code.
>
See the file below.
./drivers/i2c/muxes/i2c-mux-pca954x.c:115: { "pca9547", pca_9547 },
Perhaps the vender name should be updated to nxp.
> > + reg = <0x77>;
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + i2c at 0 {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + reg = <0x0>;
> > +
> > + rtc at 68 {
> > + compatible = "dallas,ds3232";
> > + reg = <0x68>;
> > + /* IRQ10_B */
> > + interrupts = <0 150 0x4>;
> > + };
> > + };
> > +
> > + i2c at 2 {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + reg = <0x2>;
> > +
> > + ina220 at 40 {
> > + compatible = "ti,ina220";
> > + reg = <0x40>;
> > + shunt-resistor = <1000>;
> > + };
> > +
> > + ina220 at 41 {
> > + compatible = "ti,ina220";
> > + reg = <0x41>;
> > + shunt-resistor = <1000>;
> > + };
> > + };
> > +
> > + i2c at 3 {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + reg = <0x3>;
> > +
> > + eeprom at 56 {
> > + compatible = "at24,24c512";
>
> Unsupported/undocumented compatible?
Will change it to "atmel, 24c512".
>
> > + reg = <0x56>;
> > + };
> > +
> > + eeprom at 57 {
> > + compatible = "at24,24c512";
> > + reg = <0x57>;
> > + };
> > +
> > + adt7461a at 4c {
>
> temp-sensor should be a better node name, if I understand the device correctly.
>
I didn't find a reference in kernel, so what name should be better, do you have any advice?
> > + compatible = "adt7461a";
>
> It should be "adi,adt7461a" per
> Documentation/devicetree/bindings/hwmon/lm90.txt?
>
Yes, will fix it in v3.
> > + reg = <0x4c>;
> > + };
> > + };
> > + };
> > +};
> > +
> > +&ifc {
> > + status = "okay";
>
> We generally put it at the bottom of the property list.
>
Will fix it in v3.
> > + #address-cells = <2>;
> > + #size-cells = <1>;
> > + /* NOR, NAND Flashes and FPGA on board */
> > + ranges = <0x0 0x0 0x0 0x60000000 0x08000000
> > + 0x1 0x0 0x0 0x7e800000 0x00010000
> > + 0x2 0x0 0x0 0x7fb00000 0x00000100>;
> > +
> > + nor at 0,0 {
> > + compatible = "cfi-flash";
> > + reg = <0x0 0x0 0x8000000>;
> > + bank-width = <2>;
> > + device-width = <1>;
> > + };
> > +
> > + nand at 1,0 {
> > + compatible = "fsl,ifc-nand";
> > + reg = <0x1 0x0 0x10000>;
> > + };
> > +
> > + fpga: board-control at 2,0 {
> > + compatible = "fsl,ls1043aqds-fpga", "fsl,fpga-qixis";
> > + reg = <0x2 0x0 0x0000100>;
> > + };
> > +};
> > +
> > +&lpuart0 {
> > + status = "okay";
> > +};
> > +
> > +&duart0 {
> > + status = "okay";
> > +};
> > +
> > +&duart1 {
> > + status = "okay";
> > +};
>
> I suggest you sort these node alphabetically per label name.
>
Yes, will resort these nodes in v3.
Thanks,
Zhiqiang
More information about the linux-arm-kernel
mailing list