[PATCH] drivers: net: cpsw-phy-sel: add dev_warn() for unsupported PHY mode

David Miller davem at davemloft.net
Wed Feb 17 07:51:04 PST 2016


From: "David Rivshin (Allworx)" <drivshin.allworx at gmail.com>
Date: Fri, 12 Feb 2016 19:45:36 -0500

> From: David Rivshin <drivshin at allworx.com>
> 
> The cpsw-phy-sel driver supports only MII, RMII, and RGMII PHY modes,
> and silently handled any other values as if MII was specified. In a
> case where the PHY mode was incorrectly specified, or a bug elsewhere,
> there would be no indication of a problem. If MII was the correct mode,
> then this will go unnoticed, otherwise the symptom will be a failure
> to transmit/receive data over the RMII/RGMII link.
> 
> Add a dev_warn() to make this condition obvious and provide a
> breadcrumb to follow.
> 
> Cc: Mugunthan V N <mugunthanvnm at ti.com>
> Signed-off-by: David Rivshin <drivshin at allworx.com>

Applied to 'net', thanks.  I don't think I'll queue this up for -stable.

Thanks.



More information about the linux-arm-kernel mailing list