linux-4.5-rc3/arch/arm/mach-ux500/cpu-db8500.c:89: statement after return ?

[Linus Walleij]

On Mon, Feb 8, 2016 at 4:50 PM, David Binderman <dcb314 at hotmail.com> wrote:

> Hello there,
>
> [linux-4.5-rc3/arch/arm/mach-ux500/cpu-db8500.c:89]: (style) Statements following return, break, continue, goto or throw will never be executed.
>
> Source code is
>
>     return kasprintf(GFP_KERNEL, "%08x%08x%08x%08x%08x",
>              readl((u32 *)uid+0),
>              readl((u32 *)uid+1), readl((u32 *)uid+2),
>              readl((u32 *)uid+3), readl((u32 *)uid+4));
>     iounmap(uid);
> }
>
> This looks like a cut-n-paste error to me. Suggest rework.

I sent a patch for this, nice catch.

Yours,
Linus Walleij