[PATCH] ARM: dts: porter: add MAX3355 support

Sergei Shtylyov sergei.shtylyov at cogentembedded.com
Mon Feb 15 02:59:38 PST 2016


On 2/15/2016 4:45 AM, Simon Horman wrote:

>>>>>>>> Now that Maxim Integrated MAX3355 'extcon' driver and device tree bindings
>>>>>>>> are upstream along with the 'extcon' hook  in the Renesas USBHS driver, we
>>>>>>>> can add  MAX3355 device node to  the Porter device tree and properly refer
>>>>>>>> to it from the USBHS node instead of using  "renesas,enable-gpio" property
>>>>>>>> which only allowed checking the USB ID pin  at the driver probe time;  now
>>>>>>>> this  pin's  state can be monitored dynamically!
>>>>>>>>
>>>>>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov at cogentembedded.com>
>>>>>>>
>>>>>>> I tested this patch on Porter, but interrupt of "usb-otg" didn't happened
>>>>>>> even if I connected/disconnected a usb convert cable (usb micro-ab to A).
>>>>>>> Remarks: I confirmed that the usb convert cable worked correctly on other
>>>>>>> board.
>>>>>>
>>>>>>      I guess I have the same cable
>>>>>
>>>>>      No, I have mini-AB connector here and hence my cable is mini-AB to A.
>>>>
>>>> I checked Porter specification and then I found 2 specifications exist...
>>>
>>>     I've looked thru my schematics files and found 3: Rev. 1.1 Update Version
>>> 2, "PORTER_2" Rev. 3.0 Preliminary, and "PORTER_C" Rev. 3.0 Release version!
>>> I'm not sure which of the last 2 should be considered final...
>>
>>     Now I've found 5 versions of the Porter schematics... :-)
>>
>>>>   Porter "B" : mini AB connecter and Max3355 is on the board.
>>>>   Porter "C" : micro AB connect and Max3355 is not on the board. (Select
>>>> host/peripheral by a jumper.)
>>>
>>>     Yeah, seeing JP13 in the PORTER_C schematics.
>>>
>>>> I guess that your current target is "B".
>>>
>>>     If not earlier. It actually has "Henninger B REV2" printed on it and
>>> "Porter PCB 1 R3" on a pasted sticker.
>>>
>>>> If so, I think this patch is acceptable.
>>>
>>>     I'm not so sure now...
>>
>>     My boss told me PORTER_C is a final version, so this patch isn't needed.
>> But then another patch is needed instead: to remove "renesas,enable-gpio"
>> prop from the HS-USB device node...
>
> I am marking this patch as "Rejected" in patchwork.
> If changes are required in this area please either
> resubmit this patch or post a different one.

    Posted a different one on Saturday.

> Thanks.

MBR, Sergei




More information about the linux-arm-kernel mailing list