[PATCH] of/irq: Fix msi-map calculation for nonzero rid-base
robh+dt at kernel.org
Thu Feb 11 15:15:27 PST 2016
On Thu, Feb 11, 2016 at 5:04 AM, Marc Zyngier <marc.zyngier at arm.com> wrote:
> On 09/02/16 11:04, Robin Murphy wrote:
>> The existing msi-map code is fine for shifting the entire RID space
>> upwards, but attempting finer-grained remapping reveals a bug. It turns
>> out that we are mistakenly treating the msi-base part as an offset, not
>> as a new base to remap onto, so things get squiffy when rid-base is
>> nonzero. Fix this, and at the same time add a sanity check against
>> having msi-map-mask clash with a nonzero rid-base, as that's another
>> thing one can easily get wrong.
>> CC: <stable at vger.kernel.org>
>> Signed-off-by: Robin Murphy <robin.murphy at arm.com>
> Rob, Frank,
> Are you willing to take this one through the OF tree? Or should we route
> it through the IRQ tree? It'd be good if it make it into 4.5.
Applied for 4.5. ATM, I don't have anything else to send to Linus.
I'll give it a week or so if this is not urgent. Or send me a bunch of
DT binding fixes and you can get it in sooner. ;)
More information about the linux-arm-kernel