[PATCH] ARM: OMAP3: Fix imprecise external abort for off mode on 36xx
Tony Lindgren
tony at atomide.com
Wed Feb 10 13:35:07 PST 2016
With CONFIG_DEBUG_RODATA enabled I started noticing imprecise external
aborts on a dm3730 when hitting off idle. These don't seem to happen
on 34xx.
Pretty much changing anything in the code made these go away, like
changing .config options. At first I though it might be an alignment
issue in the 36xx specific assembly code in sleep34xx.S, or something
related to the recent rodata fixes. But that does not seem to be
the case. It seems to be a timing issue instead.
Adding few extra nop instructions after the wfi seems to fix the
issue. When adding 5 nops, the errors showed up less often. With
add ed 6 nops, I don't seem to get them at all any longer.
Cc: Grygorii Strashko <grygorii.strashko at ti.com>
Cc: Nishanth Menon <nm at ti.com>
Cc: Richard Woodruff <r-woodruff2 at ti.com>
Cc: Tero Kristo <t-kristo at ti.com>
Signed-off-by: Tony Lindgren <tony at atomide.com>
---
Anybody else seen this issue before?
---
arch/arm/mach-omap2/sleep34xx.S | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/mach-omap2/sleep34xx.S b/arch/arm/mach-omap2/sleep34xx.S
index 1b9f052..0fbaa08 100644
--- a/arch/arm/mach-omap2/sleep34xx.S
+++ b/arch/arm/mach-omap2/sleep34xx.S
@@ -264,6 +264,12 @@ ENTRY(omap3_do_wfi)
nop
nop
nop
+ nop
+ nop
+ nop
+ nop
+ nop
+ nop
/*
* This function implements the erratum ID i581 WA:
--
2.7.0
More information about the linux-arm-kernel
mailing list