[PATCH v2 5/5] ARM: dts: r8a7794: add sound support

[Simon Horman]

On Wed, Feb 10, 2016 at 12:41:30AM +0000, Kuninori Morimoto wrote:
> 
> Hi Sergei
> 
> Sorry for my un-ordered response
> 
> > Define the generic R8A7794 part of  the sound device node.
> > This sound device  is a complex one and comprises the Audio Clock Generator
> > (ADG), Sampling Rate Converter Unit (SCU), Serial Sound Interface [Unit]
> > (SSI[U]), and Audio DMAC-Peripheral-Peripheral.
> > It is up  to the board file to enable the device.
> > 
> > This patch is based on the R8A7791 sound work by Kuninori Morimoto.
> > 
> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov at cogentembedded.com>
> (snip)
> > +		rcar_sound,src {
> > +			src1: src at 1 {
> > +				interrupts = <GIC_SPI 353 IRQ_TYPE_LEVEL_HIGH>;
> > +				dmas = <&audma0 0x87>, <&audma0 0x9c>;
> > +				dma-names = "rx", "tx";
> > +			};
> > +			src2: src at 2 {
> > +				interrupts = <GIC_SPI 354 IRQ_TYPE_LEVEL_HIGH>;
> > +				dmas = <&audma0 0x89>, <&audma0 0x9e>;
> > +				dma-names = "rx", "tx";
> > +			};
> > +			src3: src at 3 {
> > +				interrupts = <GIC_SPI 355 IRQ_TYPE_LEVEL_HIGH>;
> > +				dmas = <&audma0 0x8b>, <&audma0 0xa0>;
> > +				dma-names = "rx", "tx";
> > +			};
> > +			src4: src at 4 {
> > +				interrupts = <GIC_SPI 356 IRQ_TYPE_LEVEL_HIGH>;
> > +				dmas = <&audma0 0x8d>, <&audma0 0xb0>;
> > +				dma-names = "rx", "tx";
> > +			};
> > +			src5: src at 5 {
> > +				interrupts = <GIC_SPI 357 IRQ_TYPE_LEVEL_HIGH>;
> > +				dmas = <&audma0 0x8f>, <&audma0 0xb2>;
> > +				dma-names = "rx", "tx";
> > +			};
> > +			src6: src at 6 {
> > +				interrupts = <GIC_SPI 358 IRQ_TYPE_LEVEL_HIGH>;
> > +				dmas = <&audma0 0x91>, <&audma0 0xb4>;
> > +				dma-names = "rx", "tx";
> > +			};
> > +		};
> 
> I think this can't work correctly, because driver is assuming
> DT has all channles (from 0). (see linux/sound/soc/sh/rcar/src.c :: rsnd_src_probe)
> Can you adds dummy src0 with some comments ? or fix src.c driver ?

I would prefer the driver to be fixed (I had a similar patchset locally
and I found it doesn't work). The reason is that DT should describe
the hardware rather than the current state of the software.