[PATCH v2 04/10] serial: mps2-uart: add MPS2 UART driver
Greg KH
gregkh at linuxfoundation.org
Mon Feb 8 09:28:31 PST 2016
On Mon, Feb 08, 2016 at 05:17:57PM +0000, Vladimir Murzin wrote:
> On 08/02/16 16:52, Greg KH wrote:
> > On Mon, Feb 08, 2016 at 11:16:56AM +0000, Vladimir Murzin wrote:
> >> On 07/02/16 07:11, Greg KH wrote:
> >>>> +
> >>>> +#define SERIAL_NAME "ttyS"
> >>>
> >>> You can't be "ttyS", there's already a serial port named that, please
> >>> use a unique name and a new major/minor number (dynamic ideally).
> >>>
> >>
> >> Hi Greg,
> >>
> >> I did s/ttyMPS/ttyS per your request for v1 [1]. I'm fine to change it
> >> back if you prefer that, but I'd be glad to know what I've been missing?
> >>
> >> [1] https://lkml.org/lkml/2015/12/13/8
> >
> > Yeah, I was wrong, sorry about that, my fault.
> >
>
> I got -EDOUBT from my parser. What should I stick with "ttyS" or "ttyMPS"?
Please use ttyMPS.
> P.S.
> Any chance you could look at the rest of the patch?
It's long gone from my queue, sorry, you'll have to resend it.
thanks,
greg k-h
More information about the linux-arm-kernel
mailing list