[PATCH 5/6] net: thunderx: bgx: Add log message when setting mac address
Robert Richter
robert.richter at caviumnetworks.com
Mon Feb 8 05:48:35 PST 2016
On 08.02.16 16:30:37, Sergei Shtylyov wrote:
> >@@ -897,10 +898,13 @@ static int acpi_get_mac_address(struct acpi_device *adev, u8 *dst)
> > goto out;
> >
> > if (!is_valid_ether_addr(mac)) {
> >+ dev_warn(dev, "MAC address invalid: %pM\n", mac);
>
> dev_er(), maybe?
Since the driver may continue, my choice was a warning only.
-Robert
>
> > ret = -EINVAL;
> > goto out;
> > }
> >
> >+ dev_info(dev, "MAC address set to: %pM\n", mac);
> >+
> > memcpy(dst, mac, ETH_ALEN);
> > out:
> > return ret;
> [...]
More information about the linux-arm-kernel
mailing list