[PATCH v4 1/2] regulator: act8945a: add regulator driver for ACT8945A

[Yang, Wenyou]

> -----Original Message-----
> From: Mark Brown [mailto:broonie at kernel.org]
> Sent: 2016年2月4日 1:48
> To: Yang, Wenyou <Wenyou.Yang at atmel.com>
> Cc: Javier Martinez Canillas <javier at dowhile0.org>; Liam Girdwood
> <lgirdwood at gmail.com>; Rob Herring <robh+dt at kernel.org>; Pawel Moll
> <pawel.moll at arm.com>; Ian Campbell <ijc+devicetree at hellion.org.uk>; Kumar
> Gala <galak at codeaurora.org>; Krzysztof Kozlowski
> <k.kozlowski at samsung.com>; Lee Jones <lee.jones at linaro.org>; Peter
> Korsgaard <jacmet at gmail.com>; Ferre, Nicolas <Nicolas.FERRE at atmel.com>;
> linux-arm-kernel at lists.infradead.org; linux-kernel at vger.kernel.org;
> devicetree at vger.kernel.org
> Subject: Re: [PATCH v4 1/2] regulator: act8945a: add regulator driver for
> ACT8945A
> 
> On Wed, Feb 03, 2016 at 02:33:11AM +0000, Yang, Wenyou wrote:
> 
> > > I would just remove the "active-semi,act8945a-regulator" node and
> > > make "active- semi,vsel-high" a property of the "active-semi,act8945a" node.
> > > That way you can remove the mfd cell .of_compatible and OF table in
> > > the regulator driver and read the "active-semi,vsel-high" using the
> > > platform device's parent of_node.
> 
> > > But it's better if you wait for Mark's opinions before re-spining your patches.
> 
> > Hi Mark, what is your opinions?
> 
> Like Javier says you should make your DT binding look like the DT bindings for
> other MFDs and not use of_compatible.

All right.

Thank you, Mark, Javier.


Best Regards,
Wenyou Yang