[PATCH 1/2] ARM: make virt_to_idmap() return unsigned long

Russell King - ARM Linux linux at arm.linux.org.uk
Mon Feb 1 07:20:15 PST 2016


On Tue, Jan 26, 2016 at 08:27:52PM -0800, santosh.shilimkar at oracle.com wrote:
> On 1/26/16 10:21 AM, Russell King wrote:
> >Make virt_to_idmap() return an unsigned long rather than phys_addr_t.
> >
> >Returning phys_addr_t here makes no sense, because the definition of
> >virt_to_idmap() is that it shall return a physical address which maps
> >identically with the virtual address.  Since virtual addresses are
> >limited to 32-bit, identity mapped physical addresses are as well.
> >
> >Almost all users already had an implicit narrowing cast to unsigned long
> >so let's make this official and part of this interface.
> >
> >Signed-off-by: Russell King <rmk+kernel at arm.linux.org.uk>
> >---
> Looks correct to me.
> 
> Vitaly,
> Could you please try out this patch and see everything continue to
> work ?

I haven't heard anything yet...  Vitaly?

-- 
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.



More information about the linux-arm-kernel mailing list