[PATCH V1] pinctrl:pxa:pinctrl-pxa2xx:- No need of devm functions
Linus Walleij
linus.walleij at linaro.org
Fri Dec 30 05:02:56 PST 2016
On Thu, Dec 29, 2016 at 8:20 AM, Robert Jarzmik <robert.jarzmik at free.fr> wrote:
> Linus Walleij <linus.walleij at linaro.org> writes:
>
>> On Thu, Dec 8, 2016 at 3:35 PM, Arvind Yadav <arvind.yadav.cs at gmail.com> wrote:
>>
>>> In functions pxa2xx_build_functions, the memory allocated for
>>> 'functions' is live within the function only. After the
>>> allocation it is immediately freed with devm_kfree. There is
>>> no need to allocate memory for 'functions' with devm function
>>> so replace devm_kcalloc with kcalloc and devm_kfree with kfree.
>>>
>>> Signed-off-by: Arvind Yadav <arvind.yadav.cs at gmail.com>
>>
>> I want the maintainer Robert Jarzmik to review this before I do anything
>
> Hi Linus,
>
> I did review, on December the 10th. I wasn't very enthusiastic about the patch,
> if you check back my reply.
Sorry I missed it (mail overload as usual).
OK dropping this.
Yours,
Linus Walleij
More information about the linux-arm-kernel
mailing list