[PATCH v2] efi/libstub: arm*: Pass latest memory map to the kernel

Matt Fleming matt at codeblueprint.co.uk
Mon Dec 19 13:38:59 PST 2016


On Mon, 19 Dec, at 02:24:19PM, James Morse wrote:
> From: Ard Biesheuvel <ard.biesheuvel at linaro.org>
> 
> As reported by James, the current libstub code involving the annotated
> memory map only works somewhat correctly by accident, due to the fact
> that a pool allocation happens to be reused immediately, retaining its
> former contents.
> 
> Instead of juggling memory maps, which makes the code more complex than
> it needs to be, simply put a placholder value into the FDT, and only
> write the actual value after ExitBootServices() has been called.
> 
> Reported-by: James Morse <james.morse at arm.com>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel at linaro.org>
> [Update mmap-size too, remove updated_fdt()s unused params and header entry]
> Signed-off-by: James Morse <james.morse at arm.com>
> ---
> Hi Ard,
> 
> This is a v2 of your patch that updates the mmap-size too. This solves the
> truncated memmap problem I saw with v1 on Seattle.
> 
> The original patch was CC-stable, so I think this should also have:
> Cc: <stable at vger.kernel.org>
> Fixes: ed9cc156c42f ("efi/libstub: Use efi_exit_boot_services() in FDT")
> 
> 
> Thanks,
> 
> James
> 
>  drivers/firmware/efi/libstub/efistub.h |  8 ----
>  drivers/firmware/efi/libstub/fdt.c     | 75 +++++++++++++++++++++-------------
>  2 files changed, 47 insertions(+), 36 deletions(-)

Thanks James. I've queued this one up in the 'urgent' queue and tagged
it for stable. I'll send it to tip before the end of the week.



More information about the linux-arm-kernel mailing list