[PATCHv4 00/15] clk: ti: add support for hwmod clocks
Tony Lindgren
tony at atomide.com
Tue Dec 13 16:43:34 PST 2016
* Michael Turquette <mturquette at baylibre.com> [161213 14:02]:
> Quoting Tony Lindgren (2016-12-13 07:37:24)
> > For the clkctrl clocks, here's what I'd like to see. The driver should be
> > just a regular device driver along the lines we did with the ADPLL as in
> > Documentation/devicetree/bindings/clock/ti/adpll.txt.
> >
> > For the binding, something like the following should work as a minimal
> > example, this follows what we have in the hardware:
> >
> > &prm {
> > ...
> >
> > /* See "CD_WKUP Clock Domain" in 4430 TRM page 393 */
> > wkup_cm: clock at 1800 {
> > compatible = "ti,clkctrl";
> > reg = <0x1800 0x100>;
> > #clock-cells = <1>;
> > clocks = <&wkup_l4_iclk2 &wkup_32k_fclk
> > &32k_fclk &gp1_fclk>;
> > clock-output-names =
> > "sysctrl_padconf_wkup",
> > "badgap",
> > "sysctrl_general_wkup",
> > "gpio1",
> > "keyboard",
> > "sar_ram",
> > "32ktimer",
> > "gptimer1";
>
> Is there a technical reason to use clock-output-names? If you share a
> header between the clock provider driver and DT with the phandle offsets
> then we should be able to avoid this property altogether. Stephen and I
> are trying to phase this one out as much as possible.
Oh OK no reason for names, defines for the offsets will work just fine.
Regards,
Tony
More information about the linux-arm-kernel
mailing list