[PATCH V1] pinctrl:pxa:pinctrl-pxa2xx:- No need of devm functions
Robert Jarzmik
robert.jarzmik at free.fr
Sat Dec 10 01:19:07 PST 2016
Arvind Yadav <arvind.yadav.cs at gmail.com> writes:
Hi Arvind,
> In functions pxa2xx_build_functions, the memory allocated for
> 'functions' is live within the function only. After the
> allocation it is immediately freed with devm_kfree. There is
> no need to allocate memory for 'functions' with devm function
> so replace devm_kcalloc with kcalloc and devm_kfree with kfree.
That's not very true : the "need" is to spare the "manual" kfree you're adding
in your patch for one, and make it consistent with pxa2xx_build_groups() and
pxa2xx_build_state() for two.
Therefore I'm not very thrilled by this patch and unless it fixes a defect in
the driver I'd rather not have it in.
Cheers.
--
Robert
More information about the linux-arm-kernel
mailing list