[PATCH] mmc: sdhci-xenon: fix device_node_continue.cocci warnings
Julia Lawall
julia.lawall at lip6.fr
Fri Dec 9 11:08:05 PST 2016
Device node iterators put the previous value of the index variable, so an
explicit put causes a double put.
Generated by: scripts/coccinelle/iterators/device_node_continue.cocci
CC: Hu Ziji <huziji at marvell.com>
Signed-off-by: Julia Lawall <julia.lawall at lip6.fr>
Signed-off-by: Fengguang Wu <fengguang.wu at intel.com>
---
Please check on this. I have only seen the code shown below, but the rule
normally has a lot false positive rate.
url:
https://github.com/0day-ci/linux/commits/Gregory-CLEMENT/mmc-Add-support-to-Marvell-Xenon-SD-Host-Controller/20161210-002602
base:
:::::: branch date: 2 hours ago
:::::: commit date: 2 hours ago
Please take the patch only if it's a positive warning. Thanks!
sdhci-xenon.c | 1 -
1 file changed, 1 deletion(-)
--- a/drivers/mmc/host/sdhci-xenon.c
+++ b/drivers/mmc/host/sdhci-xenon.c
@@ -423,7 +423,6 @@ static int xenon_child_node_of_parse(str
MMC_CAP2_NO_SD |
MMC_CAP2_NO_SDIO;
}
- of_node_put(child);
}
return 0;
More information about the linux-arm-kernel
mailing list