[PATCH v18 03/15] clocksource/drivers/arm_arch_timer: Improve printk relevant code

Joe Perches joe at perches.com
Thu Dec 8 13:10:30 PST 2016


On Fri, 2016-12-09 at 01:33 +0800, fu.wei at linaro.org wrote:
> From: Fu Wei <fu.wei at linaro.org>
> 
> This patch defines pr_fmt(fmt) for all pr_* functions,
> then the pr_* doesn't need to add "arch_timer:" everytime.

trivia:

> diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
[]
> @@ -966,7 +967,7 @@ static int __init arch_timer_mem_init(struct device_node *np)
>  
>  	ret = -EINVAL;
>  	if (!irq) {
> -		pr_err("arch_timer: Frame missing %s irq",
> +		pr_err("Frame missing %s irq",
>  		       arch_timer_mem_use_virtual ? "virt" : "phys");
>  		goto out;
>  	}

Missing terminating newline

		pr_err("Frame missing %s irq\n",



More information about the linux-arm-kernel mailing list