[PATCH v2 3/6] mm: hugetlb: change the return type for alloc_fresh_gigantic_page

Huang Shijie shijie.huang at arm.com
Sun Dec 4 19:06:49 PST 2016


On Fri, Dec 02, 2016 at 02:56:43PM +0100, Michal Hocko wrote:
> On Mon 14-11-16 15:07:36, Huang Shijie wrote:
> > This patch changes the return type to "struct page*" for
> > alloc_fresh_gigantic_page().
> 
> OK, this makes somme sense. Other hugetlb allocation function (and page
> allocator in general) return struct page as well. Besides that int would
> make sense if we wanted to convey an error code but 0 vs. 1 just doesn't
> make any sense.
> 
> But if you are changing that then alloc_fresh_huge_page should be
> changed as well.
Okay.

> 
> > This patch makes preparation for later patch.
> > 
> > Signed-off-by: Huang Shijie <shijie.huang at arm.com>
> 
> Acked-by: Michal Hocko <mhocko at suse.com>
Thanks a lot.

Thanks
Huang Shijie



More information about the linux-arm-kernel mailing list