[PATCH v11 2/4] tee: generic TEE subsystem

[Andrew F. Davis]

On 08/22/2016 08:00 AM, Jens Wiklander wrote:
> +/*
> + * Unprivileged devices in the in the lower half range and privileged

                                ^^ in the in the
[snip]

> +
> +	rc = alloc_chrdev_region(&tee_devt, 0, TEE_NUM_DEVICES, "tee");
> +	if (rc < 0) {

if (rc) ?

[snip]

> + * Memory allocated as global shared memory is automatically freed when the
> + * TEE file pointer is closed. The @flags field uses the bits defined by
> + * TEE_SHM_* above. TEE_SHM_MAPPED must currently always be set. If

             ^^^ not really above anymore, out of file now looks like

> + * TEE_SHM_DMA_BUF global shared memory will be allocated and associated
> + * with a dma-buf handle, else driver private memory.
> + *
> + * @returns a pointer to 'struct tee_shm'

Doesn't say anything, is this really needed?

[snip]

> +/**
> + * struct tee_shm_pool_mem_info - holds information needed to create a shared
> + * memory pool
> + * @vaddr:	Virtual address of start of pool
> + * @paddr:	Physical address of start of pool
> + * @size:	Size in bytes of the pool
> + */
> +struct tee_shm_pool_mem_info {
> +	unsigned long vaddr;
> +	unsigned long paddr;

phys_addr_t paddr; ?