[PATCH] ASoC: sunxi: depend on ARCH_SUNXI

Peter Robinson pbrobinson at gmail.com
Tue Aug 23 01:34:10 PDT 2016


On Mon, Aug 22, 2016 at 3:49 PM, Arnd Bergmann <arnd at arndb.de> wrote:
> On Monday, August 22, 2016 1:12:42 PM CEST Peter Robinson wrote:
>> Depend on ARCH_SUNXI or COMPILE_TEST as it doesn't make sense to enable
>> these if the appropriate SoC they're embedded in isn't enabled.
>>
>> Signed-off-by: Peter Robinson <pbrobinson at gmail.com>
>> ---
>>  sound/soc/sunxi/Kconfig | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/sound/soc/sunxi/Kconfig b/sound/soc/sunxi/Kconfig
>> index 2a954bd..a2b62dc5 100644
>> --- a/sound/soc/sunxi/Kconfig
>> +++ b/sound/soc/sunxi/Kconfig
>> @@ -2,6 +2,7 @@ menu "Allwinner SoC Audio support"
>>
>>  config SND_SUN4I_CODEC
>>         tristate "Allwinner A10 Codec Support"
>> +       depends on ARCH_SUNXI || COMPILE_TEST
>>         select SND_SOC_GENERIC_DMAENGINE_PCM
>>         select REGMAP_MMIO
>>
>
> Makes sense, though I think it's nicer to add the dependency to the entire
> menu, so we hide that as well, and don't have to add the line to future
> entries:

Makes sense, will do a v2 shortly.

P

> diff --git a/sound/soc/sunxi/Kconfig b/sound/soc/sunxi/Kconfig
> index 2a954bd01fd8..dd2368297fd3 100644
> --- a/sound/soc/sunxi/Kconfig
> +++ b/sound/soc/sunxi/Kconfig
> @@ -1,4 +1,5 @@
>  menu "Allwinner SoC Audio support"
> +       depends on ARCH_SUNXI || COMPILE_TEST
>
>  config SND_SUN4I_CODEC
>         tristate "Allwinner A10 Codec Support"
>
> Either way
> Acked-by: Arnd Bergmann <arnd at arndb.de>



More information about the linux-arm-kernel mailing list