[PATCH v2 5/5] ARM: dts: sunxi: Use new sun7i-a20-mmc compatible on sun7i and newer

[Andre Przywara]

Hi,

On 22/08/16 08:54, Maxime Ripard wrote:
> On Mon, Aug 01, 2016 at 02:11:09PM +0100, Andre Przywara wrote:
>> Hi Hans,
>>
>> On 30/07/16 15:25, Hans de Goede wrote:
>>> Use the new sun7i-a20-mmc compatible for the mmc controllers on sun7i
>>> and newer.
>>>
>>> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
>>> ---
>>> Changes in v2:
>>> -New patch in v2 of this patch-set
>>> ---
>>>  arch/arm/boot/dts/sun6i-a31.dtsi     | 8 ++++----
>>>  arch/arm/boot/dts/sun7i-a20.dtsi     | 8 ++++----
>>>  arch/arm/boot/dts/sun8i-a23-a33.dtsi | 6 +++---
>>>  arch/arm/boot/dts/sun8i-h3.dtsi      | 6 +++---
>>>  4 files changed, 14 insertions(+), 14 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/sun6i-a31.dtsi b/arch/arm/boot/dts/sun6i-a31.dtsi
>>> index 1867af2..0d24f10 100644
>>> --- a/arch/arm/boot/dts/sun6i-a31.dtsi
>>> +++ b/arch/arm/boot/dts/sun6i-a31.dtsi
>>> @@ -469,7 +469,7 @@
>>>  		};
>>>  
>>>  		mmc0: mmc at 01c0f000 {
>>> -			compatible = "allwinner,sun5i-a13-mmc";
>>> +			compatible = "allwinner,sun7i-a20-mmc";
>>
>> But that breaks systems with newer DTs on older kernels, which do not
>> know about sun7i-a20-mmc.
> 
> That's not backward compatibility. That's the forward one, and that
> has never been something we supported.

I know, but it's unfortunate anyway and easy to fix with the above
mentioned fallback scheme.
So isn't that something that we can support anyway, despite it being not
strictly necessary? For instance I tend to load different kernels now
and then (different distro kernels, older versions for regression
checks, ...) and really like the fact that I can go with _one_ known
best DT.
I understand that that's not always possible, but on the other hand I
wouldn't give up so easily, especially if there is a nice way to achieve
compatibility without hurting anyone.

Cheers,
Andre.

> See https://www.kernel.org/doc/Documentation/devicetree/bindings/ABI.txt
> 
> Maxime
>