[PATCH v4 1/6] pinctrl: amlogic: gxbb: add the IR remote pin
Kevin Hilman
khilman at baylibre.com
Fri Aug 19 15:23:19 PDT 2016
Martin Blumenstingl <martin.blumenstingl at googlemail.com> writes:
> This adds the IR remote receiver to the AO domain devices.
nit Re: Subject: should specify IR remote *input* pin.
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl at googlemail.com>
> ---
> drivers/pinctrl/meson/pinctrl-meson-gxbb.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
> index cb4d6ad..8fffb31 100644
> --- a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
> +++ b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
> @@ -225,6 +225,8 @@ static const unsigned int i2c_sda_ao_pins[] = {PIN(GPIOAO_5, 0) };
> static const unsigned int i2c_slave_sck_ao_pins[] = {PIN(GPIOAO_4, 0) };
> static const unsigned int i2c_slave_sda_ao_pins[] = {PIN(GPIOAO_5, 0) };
>
> +static const unsigned int ir_in_ao_pins[] = {PIN(GPIOAO_7, 0) };
> +
I'm trying to keep the names here so they match the datasheet, which
calls this remote_input_ao. Please update throughout the patch.
Otherwise looks good to me. Feel free to add
Reviewed-by: Kevin Hilman <khilman at baylibre.com>
and Linus W can queue it up.
Thanks,
Kevin
More information about the linux-arm-kernel
mailing list