[PATCH] ARM: dts: socfpga: Add Macnica sodia board

Nobuhiro Iwamatsu iwamatsu at nigauri.org
Fri Aug 19 14:55:26 PDT 2016


Hi,

2016-08-19 0:01 GMT+09:00 Dinh Nguyen <dinguyen at opensource.altera.com>:
> On 08/12/2016 03:26 PM, Florian Fainelli wrote:
>> On August 12, 2016 12:53:53 PM MST, Dinh Nguyen <dinguyen at opensource.altera.com> wrote:
>>> On 07/25/2016 04:30 PM, Nobuhiro Iwamatsu wrote:
>>>> Add support for board based on the Altera Cyclone V SoC.
>>>> This board has the following functions:
>>>>     - 1 GiB of DRAM
>>>>     - 1 Gigabit ethernet
>>>>     - 1 SD card slot
>>>>     - 1 USB gadget port
>>>>     - QSPI NOR Flash
>>>>     - I2C EEPROMs and I2C RTC
>>>>     - DVI output
>>>>     - Audio port
>>>>
>>>> This commit supports without QSPI, DVI and Audio.
>>>>
>>>> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu at nigauri.org>
>>>> ---
>>>>  arch/arm/boot/dts/Makefile                   |   1 +
>>>>  arch/arm/boot/dts/socfpga_cyclone5_sodia.dts | 115
>>> +++++++++++++++++++++++++++
>>>>  2 files changed, 116 insertions(+)
>>>>  create mode 100644 arch/arm/boot/dts/socfpga_cyclone5_sodia.dts
>>>>
>>>
>>> Applied!
>>
>> This DTS still has Ethernet PHY properties (skew et al.) that are at the Ethernet MAC node level while they should be at the Ethetnet PHY node level, it is not like you tripped over that before..
>>
>
> Thanks for catching this.
>
> Nobuhiro, can you please fixup the ethernet node?
>

Okay, I will resend updated patch.
Thanks for your reivew.

> Thanks,
> Dinh

Best regards,
  Nobuhiro

-- 
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org}
   GPG ID: 40AD1FA6



More information about the linux-arm-kernel mailing list