[PATCH v2 1/2] Input: jornada720_kbd - switch to devm_* APIs
Russell King - ARM Linux
linux at armlinux.org.uk
Fri Aug 19 09:45:47 PDT 2016
On Fri, Aug 19, 2016 at 09:44:47AM -0700, Dmitry Torokhov wrote:
> On Fri, Aug 19, 2016 at 05:30:59PM +0100, Russell King wrote:
> > Switch the jornada720_kbd driver to use the devm_* APIs. This is in
> > preparation to removing the mach/irqs.h include from this driver.
> >
> > Signed-off-by: Russell King <rmk+kernel at armlinux.org.uk>
> > ---
> > drivers/input/keyboard/jornada720_kbd.c | 38 ++++++++-------------------------
> > 1 file changed, 9 insertions(+), 29 deletions(-)
> >
> > diff --git a/drivers/input/keyboard/jornada720_kbd.c b/drivers/input/keyboard/jornada720_kbd.c
> > index 421d9c55b0e8..4b2e9ff18ba1 100644
> > --- a/drivers/input/keyboard/jornada720_kbd.c
> > +++ b/drivers/input/keyboard/jornada720_kbd.c
> > @@ -53,6 +53,7 @@ static unsigned short jornada_std_keymap[128] = { /* ROW */
> > struct jornadakbd {
> > unsigned short keymap[ARRAY_SIZE(jornada_std_keymap)];
> > struct input_dev *input;
> > + int irq;
>
> I do not think you need this, not in this patch and the next one does
> not seem to need this either?
>
> Can I drop this chunk?
Yes, that was accidentally left in while I was considering how to update
the driver. It can be safely dropped. Thanks for spotting that.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
More information about the linux-arm-kernel
mailing list