[PATCH 1/3] Error: Fix mmdc compilation errors due to cpu notifier
Zhengyu Shen
zhengyu.shen at nxp.com
Fri Aug 19 08:28:17 PDT 2016
> Subject: [PATCH 1/3] Error: Fix mmdc compilation errors due to cpu notifier
>
> ---
> arch/arm/mach-imx/mmdc.c | 89 ++++++++++++++++++++++---------------
> ---------
> include/linux/cpuhotplug.h | 1 +
> 2 files changed, 44 insertions(+), 46 deletions(-)
>
> diff --git a/arch/arm/mach-imx/mmdc.c b/arch/arm/mach-imx/mmdc.c
> index 372b59c..95c222d 100644
> --- a/arch/arm/mach-imx/mmdc.c
> +++ b/arch/arm/mach-imx/mmdc.c
> @@ -77,13 +77,14 @@ struct mmdc_pmu
> struct pmu pmu;
> void __iomem *mmdc_base;
> cpumask_t cpu;
> - struct notifier_block cpu_nb;
> struct hrtimer hrtimer;
> unsigned int irq;
> struct device *dev;
> struct perf_event *mmdc_events[MMDC_NUM_COUNTERS]; };
>
> +static struct mmdc_pmu *pmu_mmdc;
> +
I'm not sure it's a good idea to make the pmu static. I looked at several
other drivers for perf and most of them didn't have the pmu wrapper
as a static variable. Almost every other file which involves pmus uses
the container_of macro to get the pmu wrapper from the event.
I also looked over some documentation and some internal code and there
are two MMDCs on i.MX6 Quad although one appears to be unused.
I think just to be on the safe side it should not be made static.
More information about the linux-arm-kernel
mailing list