[PATCH 1/2] net: phy: Add error checks in the driver
Appana Durga Kedareswara Rao
appana.durga.rao at xilinx.com
Fri Aug 19 06:18:12 PDT 2016
Hi Andrew,
Thanks for the review...
> > - mdiobus_write(phydev->mdio.bus, priv->addr,
> XILINX_GMII2RGMII_REG, val);
> > + err = mdiobus_write(phydev->mdio.bus, priv->addr,
> XILINX_GMII2RGMII_REG,
> > + val);
> > + if (err < 0)
> > + return err;
> >
> > return 0;
>
> Do you need to assign err? Why not just
Ok will fix in the next version....
Regards,
Kedar.
>
> return mdiobus_write(phydev->mdio.bus, priv->addr,
> XILINX_GMII2RGMII_REG,
> val);
More information about the linux-arm-kernel
mailing list