[PATCH v5 5/6] usb: chipidea: let chipidea core device of_node equal's glue layer device of_node
Stephen Boyd
stephen.boyd at linaro.org
Tue Aug 9 17:15:36 PDT 2016
Quoting Peter Chen (2016-08-08 01:52:10)
> From: Peter Chen <peter.chen at freescale.com>
>
> At device tree, we have no device node for chipidea core,
> the glue layer's node is the parent node for host and udc
> device. But in related driver, the parent device is chipidea
> core. So, in order to let the common driver get parent's node,
> we let the core's device node equals glue layer device node.
>
> Signed-off-by: Peter Chen <peter.chen at freescale.com>
> Tested-by: Maciej S. Szmigiero <mail at maciej.szmigiero.name>
> Tested-by Joshua Clayton <stillcompiling at gmail.com>
> ---
> drivers/usb/chipidea/core.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
> index 69426e6..b189dc7 100644
> --- a/drivers/usb/chipidea/core.c
> +++ b/drivers/usb/chipidea/core.c
> @@ -954,6 +954,15 @@ static int ci_hdrc_probe(struct platform_device *pdev)
> dev_err(dev, "unable to init phy: %d\n", ret);
> return ret;
> }
> + /*
> + * At device tree, we have no device node for chipidea core,
> + * the glue layer's node is the parent node for host and udc
> + * device. But in related driver, the parent device is chipidea
> + * core. So, in order to let the common driver get parent's node,
> + * we let the core's device node equals glue layer's node.
> + */
> + if (dev->parent && dev->parent->of_node)
> + dev->of_node = dev->parent->of_node;
Can this be done earlier? Perhaps after hw_device_init() in this probe
routine? That would allow me to remove the awkward parent searching in
my ULPI DT awareness patch.
More information about the linux-arm-kernel
mailing list