[PATCH v12 02/11] genirq/msi: msi_compose wrapper
Thomas Gleixner
tglx at linutronix.de
Tue Aug 9 02:19:18 PDT 2016
On Tue, 2 Aug 2016, Eric Auger wrote:
> Currently the MSI message is composed by directly calling
> irq_chip_compose_msi_msg and erased by setting the memory to zero.
>
> On some platforms, we will need to complexify this composition to
> properly handle MSI emission through IOMMU. Also we will need to track
> when the MSI message is erased.
I just can't find how you do that. After applying the series the
> + if (erase)
> + memset(msg, 0, sizeof(*msg));
branch is still just a memset(). The wrapper is fine for the compose side, but
having the extra argument just to wrap the memset() for no gain is silly.
Thanks,
tglx
More information about the linux-arm-kernel
mailing list