[PATCH v18 6/6] ARM: socfpga: fpga bridge driver support

Moritz Fischer moritz.fischer at ettus.com
Mon Aug 8 13:44:59 PDT 2016


Hi Alan,

On Mon, Aug 8, 2016 at 12:18 PM, atull <atull at opensource.altera.com> wrote:

>> Please don't use module.h in drivers controlled by a bool
>> Kconfig setting.
>>
>> THanks,
>> Paul.
>>
>
> Thanks for the feedback.  Can you provide an example of what you
> would consider to be proper usage in the kernel?


I think Paul is suggesting to use

static int __init alt_fpga_bridge_init(void)
{
        platform_driver_register(&alt_fpga_bridge_driver);
}

device_initcall(alt_fpga_bridge_init);

or better:

builtin_platform_driver(&alt_fpga_bridge_driver);

Like for example in: drivers/cpuidle/cpuidle-mvebu-v7.c

Cheers,

Moritz



More information about the linux-arm-kernel mailing list