[PATCH 2/2] dt: bindings: Add binding for ESP8089 wifi chips

[Chen-Yu Tsai]

Hi Arnd,

On Mon, Aug 8, 2016 at 3:59 AM, Arnd Bergmann <arnd at arndb.de> wrote:
> On Sunday, August 7, 2016 8:57:49 PM CEST Hans de Goede wrote:
>> +Espressif ESP8089 wireless SDIO devices
>> +
>> +This node provides properties for controlling the ESP8089 wireless device.
>> +The node is expected to be specified as a child node to the SDIO controller
>> +that connects the device to the system.
>> +
>> +Required properties:
>> +
>> + - compatible : Should be "esp,esp8089".
>
> I think it would be good to standardize a compatible string for sdio
> like we have it for other discoverable buses, based on the
> vendor/device ID (or whatever this uses), using something like
>
> compatible = "sdio1234,5678", "esp,esp8089";

Is there a central repository for SDIO vendor/device IDs similar to
PCI or USB IDs?

The vendor ID Espressif uses is 0x6666, which seems kind of bogus to me.

ChenYu

>
>> +Optional properties:
>> + - esp,crystal_26M_en: Integer value for the crystal_26M_en firmware parameter
>
> better use '-' instead of '_' for property names.
>
>         Arnd
>
>