[PATCH 1/4] ARM: dts: sun8i: Extend Orange Pi PC dt to also handle the PC Plus

Hans de Goede hdegoede at redhat.com
Sun Aug 7 07:25:20 PDT 2016


Hi,

On 28-07-16 22:36, Hans de Goede wrote:
> Hi,
>
> On 28-07-16 20:17, Maxime Ripard wrote:
>> Hi Hans,
>>
>> On Tue, Jul 26, 2016 at 11:07:23PM +0200, Hans de Goede wrote:
>>>>>> Nothing prevents you from including the orange pi pc dts, from the
>>>>>> orange pi plus dts.
>>>>>>
>>>>>> It prevents the duplication you were trying to avoid, and it doesn't
>>>>>> create all those spurious errors and devices.
>>>>>
>>>>> That would solve the copy paste problem on the kernel side, but that
>>>>> would still mean adding a new u-boot defconfig for this, which means that
>>>>> all the distro's which ship with prebuild u-boot binaries need to build
>>>>> for yet another board, something which I would like to avoid.
>>>>
>>>> Still, registering devices that are not present on the board is not an
>>>> option.
>>>
>>> Ok, new version send.
>>>
>>> What about the other 3 patches in this series ?
>>
>> I guess the same comment applies for patch 2.
>
> The difference is that there really is no harm at all from
> enabling the extra usb controllers used on the plus 2e
> on the plus and plus 2 as well, no errors, no nothing, they
> just sit their as usb controllers without an usb device plugged
> in. But if you insist I can do a separate dts + u-boot defconfig
> for the plus 2e as well (but I would rather not).

Ping, what is the verdict on this, are you ok with the patch or
do you want me to create a separate dts file for the Orange Pi
Plus 2E, note that doing so is going to be highly confusing to
users, there are 3 plus boards:

Orange Pi Plus
Orange Pi Plus 2   (same as the original plus but with 2G RAM, uses same u-boot defconfig / dts file)
Orange Pi Plus 2E  (drops the USB-hub instead using all 3 host controllers)

So if you insist on a separate dts for the 2E, we get a case where
the user with the "2" needs to guess which config to use, sure we
can document this, but who is going to read the docs ?

Regards,

Hans



More information about the linux-arm-kernel mailing list