[PATCH v2 03/11] doc/devicetree: Add Aspeed clock bindings

[Heiko Stübner]

Hi Joel,

Am Mittwoch, 27. April 2016, 18:01:00 schrieb Joel Stanley:
> On Thu, Apr 21, 2016 at 8:50 PM, Heiko Stübner <heiko at sntech.de> wrote:
> > [+clock-related patches should include clock-maintainers and lists]
> 
> Thanks.
> 
> > Am Donnerstag, 21. April 2016, 17:34:01 schrieb Joel Stanley:
> >> +For example:
> >> +
> >> +     clk_clkin: clk_clkin {
> >> +             #clock-cells = <0>;
> >> +             compatible = "fixed-clock";
> >> +             clock-frequency = <48000000>;
> >> +     };
> >> +
> >> +     clk_hpll: clk_hpll {
> >> +             compatible = "aspeed,g4-hpll-clock";
> >> +             #clock-cells = <0>;
> >> +             reg = <0x1e6e2008 0x4>;
> >> +     };
> >> +
> >> +     clk_apb: clk_apb at 1e6e2008 {
> >> +             #clock-cells = <0>;
> >> +             compatible = "aspeed,g4-apb-clock";
> >> +             reg = <0x1e6e2008 0x4>;
> >> +             clocks = <&clk_hpll>;
> >> +     };
> > 
> > You have both the hpll and apb_clk in the same register (probably even
> > more
> > clocks?) and separate clock instances where each instance will of_iomap
> > the
> > register itself (and thus multiple times in general).
> 
> Yep. I agree that's not ideal.
> 
> > From what I remember exposing the clock controller as one block (instead
> > of
> > declaring each clock individually in the dts) is still the preferred way
> > but I don't think I can find Mike's mail from back then easily.
> 
> I can't picture how that would look. I took my lead from the moxart
> clock driver; is there a better example that I should follow?

qcom, samsung, rockchip, hisilicon, imx, ...

I guess the design would depend on the actual layout of your clock- / system-
controller - aka what else is contained there.


Heiko