[PATCH 2/2] dmaengine: vdma: Add clock support

[Appana Durga Kedareswara Rao]

Hi Moritz,

        Thanks for the review...

> -----Original Message-----
> From: Moritz Fischer [mailto:moritz.fischer at ettus.com]
> Sent: Thursday, April 21, 2016 12:09 AM
> To: Appana Durga Kedareswara Rao <appanad at xilinx.com>
> Cc: Rob Herring <robh+dt at kernel.org>; pawel.moll at arm.com; Mark Rutland
> <mark.rutland at arm.com>; Ian Campbell <ijc+devicetree at hellion.org.uk>;
> Kumar Gala <galak at codeaurora.org>; Michal Simek <michals at xilinx.com>;
> Soren Brinkmann <sorenb at xilinx.com>; Vinod Koul <vinod.koul at intel.com>;
> Dan Williams <dan.j.williams at intel.com>; Appana Durga Kedareswara Rao
> <appanad at xilinx.com>; Laurent Pinchart
> <laurent.pinchart at ideasonboard.com>; Luis de Bethencourt
> <luis at debethencourt.com>; Anirudha Sarangi <anirudh at xilinx.com>; Punnaiah
> Choudary Kalluri <punnaia at xilinx.com>; Devicetree List
> <devicetree at vger.kernel.org>; linux-arm-kernel <linux-arm-
> kernel at lists.infradead.org>; Linux Kernel Mailing List <linux-
> kernel at vger.kernel.org>; dmaengine at vger.kernel.org
> Subject: Re: [PATCH 2/2] dmaengine: vdma: Add clock support
>
> Hi,
>
> thanks for looking into this.
>
> On Wed, Apr 20, 2016 at 12:20 AM, Kedareswara rao Appana
> <appana.durga.rao at xilinx.com> wrote:
>
> > +static int xdma_clk_init(struct xilinx_dma_device *xdev, bool enable)
> > +{
> > +       int i = 0, ret;
> > +
> > +       for (i = 0; i < xdev->numclks; i++) {
> > +               if (enable) {
> > +                       ret = clk_prepare_enable(xdev->clks[i]);
> > +                       if (ret) {
> > +                               dev_err(xdev->dev,
> > +                                       "failed to enable the axidma clock\n");
> > +                               return ret;
>
> What happens to the ones you already turned on, if say the third fails?

Will fix in the next version of the patch...

Regards,
Kedar.
>
> Cheers,
>
> Moritz


This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.