[PATCH V2 2/3] dmaengine: bcm2835: use platform_get_irq_byname
Martin Sperl
kernel at martin.sperl.org
Wed Apr 20 04:06:15 PDT 2016
On 20.04.2016 08:51, Geert Uytterhoeven wrote:
> On Mon, Apr 11, 2016 at 3:29 PM, <kernel at martin.sperl.org> wrote:
>> From: Martin Sperl <kernel at martin.sperl.org>
>>
>> Use platform_get_irq_byname to allow for correct mapping of
>> interrupts to dma channels.
>>
>> The currently implemented device tree is unfortunately
>> implemented with the wrong assumption, that each dma-channel
>> has its own dma channel, but dma-irq 11 is handling
>> dma-channel 11-14 and dma-irq 12 is actually a "catch all"
>> interrupt.
>>
>> So here we use the byname variant and require that interrupts
>> are explicitly named via the interrupts-name property in the
>
> interrupt-names
Vinod has just merged this patch - do you want me to submit another
to correct those?
> You're not explicitly looking for "dma-shared-all" for that?
> You might as well just declare a single unnamed interrupt in the bindings.
dma-shared-all is unfortunately an interrupt-line that triggers
for interrupt-channels 0-15 and that includes the dma channels
that are owned by the firmware.
It is there mostly to document the interrupt-line (which is there in the
existing device tree files - it is not used.
Martin
More information about the linux-arm-kernel
mailing list