[PATCH v4] ASoC: mediatek: Add second I2S on mt8173-rt5650 machine driver

Mark Brown broonie at kernel.org
Mon Apr 18 10:22:03 PDT 2016


On Mon, Apr 18, 2016 at 08:43:39PM +0800, PC Liao wrote:

> +Optional properties:
> +- sound-dai: audio codec dai on capture path
> +  <&rt5650 0> : Default setting. Connect rt5650 I2S1 for capture. (dai_name = rt5645-aif1)
> +  <&rt5650 1> : Connect rt5650 I2S2 for capture. (dai_name = rt5645-aif2)

Code-wise this seems fine but it seems like it'd be clearer to call this
capture-dai - this isn't used to select whatr's used for playback, only
for capture.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160418/fdc7ad94/attachment.sig>


More information about the linux-arm-kernel mailing list