[PATCH V2 03/15] coresight: tmc: re-implementing tmc_read_prepare/unprepare() functions

Suzuki K Poulose Suzuki.Poulose at arm.com
Fri Apr 15 10:41:17 PDT 2016


On 15/04/16 16:40, Mathieu Poirier wrote:
> On 14 April 2016 at 11:11, Suzuki K Poulose <Suzuki.Poulose at arm.com> wrote:

>>
>> Nit. If you move the TMC_CONFIG_TYPE_ETB here, you could fall through from
>> TYPE_ETF: i.e,
>
> Yes, that's what the end result look like [1].  I will refactor to
> make the transition cleaner.
>
> [1]. https://git.linaro.org/kernel/coresight.git/blob/refs/heads/next:/drivers/hwtracing/coresight/coresight-tmc.c#l76

Ok, no need to refactor here then.

>>
>> Reviewed-by: Suzuki K Poulose <suzuki.poulose at arm.com>

Cheers
Suzuki




More information about the linux-arm-kernel mailing list