[PATCH RFT 1/5] iio: mxs-lradc: fix memory leak
Stefan Wahren
stefan.wahren at i2se.com
Thu Apr 14 08:48:25 PDT 2016
After successful touchscreen registration the input device was
never freed. So fix this issue by using devm_input_allocate_device().
Signed-off-by: Stefan Wahren <stefan.wahren at i2se.com>
---
drivers/iio/adc/mxs-lradc.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/iio/adc/mxs-lradc.c b/drivers/iio/adc/mxs-lradc.c
index 33051b8..0576953 100644
--- a/drivers/iio/adc/mxs-lradc.c
+++ b/drivers/iio/adc/mxs-lradc.c
@@ -1109,12 +1109,11 @@ static int mxs_lradc_ts_register(struct mxs_lradc *lradc)
{
struct input_dev *input;
struct device *dev = lradc->dev;
- int ret;
if (!lradc->use_touchscreen)
return 0;
- input = input_allocate_device();
+ input = devm_input_allocate_device(dev);
if (!input)
return -ENOMEM;
@@ -1134,11 +1133,8 @@ static int mxs_lradc_ts_register(struct mxs_lradc *lradc)
lradc->ts_input = input;
input_set_drvdata(input, lradc);
- ret = input_register_device(input);
- if (ret)
- input_free_device(lradc->ts_input);
- return ret;
+ return input_register_device(input);
}
static void mxs_lradc_ts_unregister(struct mxs_lradc *lradc)
--
1.7.9.5
More information about the linux-arm-kernel
mailing list