[PATCH 2/2] ARM: shmobile: timer: Drop support for Cortex A8

Olof Johansson olof at lixom.net
Wed Apr 13 12:41:49 PDT 2016


Hi,

On Sun, Apr 3, 2016 at 6:22 PM, Simon Horman <horms+renesas at verge.net.au> wrote:
> From: Geert Uytterhoeven <geert+renesas at glider.be>
>
> Commit edf4100906044225 ("ARM: shmobile: sh7372 dtsi: Remove Legacy
> file") removed the DTS for the last shmobile SoC with a Cortex A8 CPU
> core (sh7372 aka SH-Mobile AP4).
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas at glider.be>
> Signed-off-by: Simon Horman <horms+renesas at verge.net.au>
> ---
>  arch/arm/mach-shmobile/timer.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-shmobile/timer.c b/arch/arm/mach-shmobile/timer.c
> index 67d79f9c6bad..1fc7759feab1 100644
> --- a/arch/arm/mach-shmobile/timer.c
> +++ b/arch/arm/mach-shmobile/timer.c
> @@ -54,9 +54,7 @@ void __init shmobile_init_delay(void)
>                 if (!of_property_read_u32(np, "clock-frequency", &freq))
>                         max_freq = max(max_freq, freq);
>
> -               if (of_device_is_compatible(np, "arm,cortex-a8")) {
> -                       div = 2;
> -               } else if (of_device_is_compatible(np, "arm,cortex-a9")) {
> +               if (of_device_is_compatible(np, "arm,cortex-a9")) {
>                         div = 1;
>                 } else if (of_device_is_compatible(np, "arm,cortex-a7") ||
>                          of_device_is_compatible(np, "arm,cortex-a15")) {

This setting of div doesn't make much sense now. It's always 1. This
function seems more complicated than it has to be...


-Olof



More information about the linux-arm-kernel mailing list