[PATCH] atmel-isc: fix compare_const_fl.cocci warnings
Wu, Songjun
songjun.wu at atmel.com
Wed Apr 13 02:24:37 PDT 2016
Accept.
Thank you for your comments.
On 4/13/2016 16:49, Julia Lawall wrote:
> Move constants to the right of binary operators.
>
> Generated by: scripts/coccinelle/misc/compare_const_fl.cocci
>
> CC: Songjun Wu <songjun.wu at atmel.com>
> Signed-off-by: Fengguang Wu <fengguang.wu at intel.com>
> Signed-off-by: Julia Lawall <julia.lawall at lip6.fr>
> ---
>
> Up to you. Seems a tiny bit more readable to me not to have ISC_DCTRL and
> ISC_DCTRL_IE_IS right together.
>
> atmel-isc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/media/platform/atmel/atmel-isc.c
> +++ b/drivers/media/platform/atmel/atmel-isc.c
> @@ -639,7 +639,7 @@ static inline void isc_start_dma(struct
>
> addr = vb2_dma_contig_plane_dma_addr(&frm->vb.vb2_buf, 0);
>
> - regmap_write(regmap, ISC_DCTRL, ISC_DCTRL_IE_IS | dview);
> + regmap_write(regmap, ISC_DCTRL, dview | ISC_DCTRL_IE_IS);
> regmap_write(regmap, ISC_DAD0, addr);
> regmap_update_bits(regmap, ISC_CTRLEN,
> ISC_CTRLEN_CAPTURE_MASK, ISC_CTRLEN_CAPTURE);
>
More information about the linux-arm-kernel
mailing list