[PATCH] ARM: mach-imx: sdhci-esdhc-imx: initialize DMA mask
adrian.hunter at intel.com
Wed Apr 13 01:07:16 PDT 2016
On 13/04/16 05:02, Alexandre Courbot wrote:
> On 04/13/2016 12:31 AM, Russell King - ARM Linux wrote:
>> On Tue, Apr 12, 2016 at 09:25:04PM +0900, Alexandre Courbot wrote:
>>> Clearly these devices need to be fixed. If we want to give them a grace
>>> period, we could also (temporarily) not propagate the return value of
>>> dma_set_mask_and_coherent() and limit ourselves to emitting a big warning
>>> about the inconsistency of having SDHCI_USE_SDMA/SDHCI_USE_ADMA in the host
>>> flags while not setting a dma mask.
>> Isn't it just easier to fix the root problem? It'll be one patch.
>> There's no need to add churn by changing sdhci stuff, then fixing the
>> imx stuff, and then reverting the sdhci changes.
> I think Adrian was concerned that other SDHCI drivers might unknowingly be
> in the same case.
Yes, that is the concern.
> That being said I am also in favor of fixing the root
> issue instead of adding temporary glue that we might eventually forget to
Yes, temporary glue just defers the problem.
> How long it will take for everyone to fix their drivers is another question,
> since the device doesn't clearly break, but falls back to a degraded mode
> with a warning.
It looks like DeviceTree, PCI and ACPI enumerated devices always set up a
dma_mask. I guess that just leaves devices enumerated from hard-coded
platform data. I will have a look for any more of those, and also send an
email for affected people to check their device setup and drivers.
More information about the linux-arm-kernel