[PATCH] ARM: OMAP2+: hwmod: fix _idle() hwmod state sanity check sequence

Paul Walmsley paul at pwsan.com
Sun Apr 10 16:02:30 PDT 2016


Hi Suman

On Sun, 10 Apr 2016, Suman Anna wrote:

> >> There are couple of pr_debug statements that only print once the code
> >> flow passes through certain conditions. Not sure if you wanted them
> >> to be printed first thing when entering the functions or only if the
> >> function is really doing something. But it is still not consistent
> >> between _enable(), _idle() and _shutdown().
> > 
> > Yeah those need to be cleaned up.  Seems like the best thing to do 
> > is to move them all to the beginning of their respective functions.
> 
> You want that fixed in this patch or a separate patch?

A separate one would be great.  No rush



- Paul



More information about the linux-arm-kernel mailing list