[PATCH] KVM: arm/arm64: Handle forward time correction gracefully
agraf at suse.de
Wed Apr 6 02:14:15 PDT 2016
On 04/06/2016 10:37 AM, Marc Zyngier wrote:
> On a host that runs NTP, corrections can have a direct impact on
> the background timer that we program on the behalf of a vcpu.
> In particular, NTP performing a forward correction will result in
> a timer expiring sooner than expected from a guest point of view.
> Not a big deal, we kick the vcpu anyway.
> But on wake-up, the vcpu thread is going to perform a check to
> find out whether or not it should block. And at that point, the
> timer check is going to say "timer has not expired yet, go back
> to sleep". This results in the timer event being lost forever.
> There are multiple ways to handle this. One would be record that
> the timer has expired and let kvm_cpu_has_pending_timer return
> true in that case, but that would be fairly invasive. Another is
> to check for the "short sleep" condition in the hrtimer callback,
> and restart the timer for the remaining time when the condition
> is detected.
> This patch implements the latter, with a bit of refactoring in
> order to avoid too much code duplication.
> Reported-by: Alexander Graf <agraf at suse.de>
> Signed-off-by: Marc Zyngier <marc.zyngier at arm.com>
Looks good, I can give it a test run later as well, but for now
Reviewed-by: Alexander Graf <agraf at suse.de>
More information about the linux-arm-kernel