[PATCH v8] acpi, apei, arm64: APEI initial support for aarch64.
tn at semihalf.com
Mon Apr 4 01:32:37 PDT 2016
On 30.03.2016 09:05, Ard Biesheuvel wrote:
> On 29 March 2016 at 09:44, <fu.wei at linaro.org> wrote:
>> From: Tomasz Nowicki <tomasz.nowicki at linaro.org>
>> This commit provides APEI arch-specific bits for aarch64
>> (1)add a new subfunction "hest_ia32_init" for
>> "acpi_disable_cmcff" which is used by IA-32 Architecture
>> Corrected Machine Check (CMC).
>> (2)move HEST type (ACPI_HEST_TYPE_IA32_CORRECTED_CHECK) checking to
>> a generic place.
>> (3)select EFI when ACPI_APEI is set on ARM64,
>> because arch_apei_get_mem_attribute is using efi_mem_attributes on ARM64.
> I think selecting 'EFI' is not the right approach here, especially
> since EFI is implied by ACPI on that architecture. But selecting a
> user configurable option like this is typically not recommended. Why
> doesn't ACPI_APEI depend on ACPI?
It does, ACPI_APEI is subsection of the main ACPI menu option, but I
don't see that ACPI implies EFI in Kconfig.
Also, I agree with Ard, EFI should not be selected conditionally for
ARM64 for ACPI_APEI.
We need EFI only for ARM64 so how about:
+ select HAVE_ACPI_APEI if (ACPI && EFI)
in arch/arm64/Kconfig and leave ACPI_APEI as is?
More information about the linux-arm-kernel