[PATCH] arm64: KVM: Add braces to multi-line if statement in virtual PMU code
christoffer.dall at linaro.org
Fri Apr 1 05:10:34 PDT 2016
On Fri, Apr 01, 2016 at 12:36:25PM +0100, Will Deacon wrote:
> On Fri, Apr 01, 2016 at 01:30:40PM +0200, Christoffer Dall wrote:
> > On Fri, Apr 01, 2016 at 12:12:22PM +0100, Will Deacon wrote:
> > > The kernel is written in C, not python, so we need braces around
> > > multi-line if statements. GCC 6 actually warns about this, thanks to the
> > > fantastic new "-Wmisleading-indentation" flag:
> > We should rewrite the kernel in python!
> Oh man, you made me look and I found this:
Haha, the reply saying "Great idea, go for it!" is hilarious.
> but, today's certainly the day for whacky suggestions.
I wanted to have sent you and Catalin my Linux in EL2 patch set today,
but it was still too messy and hacked up for that to be funny,
> > > | virt/kvm/arm/pmu.c: In function ‘kvm_pmu_overflow_status’:
> > > | virt/kvm/arm/pmu.c:198:3: warning: statement is indented as if it were guarded by... [-Wmisleading-indentation]
> > > | reg &= vcpu_sys_reg(vcpu, PMCNTENSET_EL0);
> > > | ^~~
> > > | arch/arm64/kvm/../../../virt/kvm/arm/pmu.c:196:2: note: ...this ‘if’ clause, but it is not
> > > | if ((vcpu_sys_reg(vcpu, PMCR_EL0) & ARMV8_PMU_PMCR_E))
> > > | ^~
> > >
> > > As it turns out, this particular case is harmless (we just do some &=
> > > operations with 0), but worth fixing nonetheless.
> > >
> > > Signed-off-by: Will Deacon <will.deacon at arm.com>
> > Thanks for the patch.
> No problem. I timed it nicely with your pull request.
Yeah, I figure I will just add it to the next pull request, unless
anyone objects to that.
More information about the linux-arm-kernel