[PATCH] ARM: sa1100: Initialize gpio after gpio subsystem has been initialized

Linus Walleij linus.walleij at linaro.org
Fri Apr 1 01:04:57 PDT 2016

On Thu, Mar 31, 2016 at 6:21 PM, Guenter Roeck <linux at roeck-us.net> wrote:
> On Tue, Mar 29, 2016 at 11:15:49AM -0700, Guenter Roeck wrote:
>> The sa1100 gpio driver was initialized from interrupt initialization code,
>> which is earlier than the gpio subsystem is initialized. Since commit
>> ff2b13592299 ("gpio: make the gpiochip a real device"), this is fatal
>> and causes the system to crash.
>> The sa1100 gpio driver must be initialized prior to arch_initcall, since
>> its gpio pins are used in arch_initcall code, but after the gpio subsystem
>> is initialized (core_initcall). Initialize it with postcore_initcall.
>> Fixes: ff2b13592299 ("gpio: make the gpiochip a real device")
>> Cc: Linus Walleij <linus.walleij at linaro.org>
>> Signed-off-by: Guenter Roeck <linux at roeck-us.net>
> Please ignore/drop this patch - a better (cleaner) fix is in the works
> for gpiolib.

This delivers though. I tested it on my also regressing iPAQ.

Linus Walleij

More information about the linux-arm-kernel mailing list