[PATCH v2 2/9] dmaengine: st_fdma: Add st fdma platform specific header
Arnd Bergmann
arnd at arndb.de
Tue Sep 29 04:10:32 PDT 2015
On Tuesday 29 September 2015 10:24:42 Peter Griffin wrote:
> On Fri, 11 Sep 2015, Arnd Bergmann wrote:
>
> > On Friday 11 September 2015 15:14:24 Peter Griffin wrote:
> > > Signed-off-by: Ludovic Barre <ludovic.barre at st.com>
> > > Signed-off-by: Peter Griffin <peter.griffin at linaro.org>
> > > ---
> > > include/linux/platform_data/dma-st_fdma.h | 72 +++++++++++++++++++++++++++++++
> > > 1 file changed, 72 insertions(+)
> > > create mode 100644 include/linux/platform_data/dma-st_fdma.h
> > >
> >
> > This clearly needs an explanation of which platforms require the header.
> >
> > On ARM, all new platforms use DT, so it's obviously not one of them.
>
> I will move the relevant parts into the st_fdma.h header file, as no other platforms
> will be upstreamed that are not DT based.
Ok, it's possible that you can simplify the code a bit after you do that,
e.g. if you can fold the st_fdma_platform_data structure into the main
per-device structure, and if you remove the filter function.
Arnd
More information about the linux-arm-kernel
mailing list