[PATCH] arm-cci500: Workaround pmu_event_set_period
Russell King - ARM Linux
linux at arm.linux.org.uk
Fri Sep 25 09:05:46 PDT 2015
As you're posting an update to CCI500, I thought I'd hijack this
thread to complain about the same thing that I complained about
with CCI400:
+config ARM_CCI500_PMU
+ bool "ARM CCI500 PMU support"
+ default y
+ depends on (ARM && CPU_V7) || ARM64
+ depends on PERF_EVENTS
+ select ARM_CCI_PMU
Why "default y" ? Not all ARMv7 CPUs have the CCI bus, and what it
means is that when moving forward, it's a pain to remember to turn
the option off amongst all the other Kconfig questions.
Only make things "default y" if it was something that was built in
a previous kernel and not building it in a later kernel would cause
a regression, or where it's absolutely necessary to do so.
Thanks.
--
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
More information about the linux-arm-kernel
mailing list