[PATCH v2 07/10] dts/ls2085a: Update DTSI to add support of various peripherals

[Sharma Bhupesh]

> From: Marc Zyngier [mailto:marc.zyngier at arm.com]
> Sent: Friday, September 04, 2015 4:25 PM

[snip] ..

> >  arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi |  469
> > +++++++++++++++++++++++-
> >  1 file changed, 459 insertions(+), 10 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi
> > b/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi
> > index 333d942..5fee0a7 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi
> 
> [...]
> 
> >  	gic: interrupt-controller at 6000000 {
> >  		compatible = "arm,gic-v3";
> >  		reg = <0x0 0x06000000 0 0x10000>, /* GIC Dist */
> > -		      <0x0 0x06100000 0 0x100000>; /* GICR (RD_base +
> SGI_base) */
> > +		      <0x0 0x06100000 0 0x100000>, /* GICR (RD_base +
> SGI_base) */
> > +		      <0x0 0x0c0c0000 0 0x2000>, /* GICC */
> > +		      <0x0 0x0c0d0000 0 0x1000>, /* GICH */
> > +		      <0x0 0x0c0e0000 0 0x20000>; /* GICV */
> >  		#interrupt-cells = <3>;
> > +		#address-cells = <2>;
> > +		#size-cells = <2>;
> > +		ranges;
> >  		interrupt-controller;
> >  		interrupts = <1 9 0x4>;
> > +
> > +		its: gic-its at 6020000 {
> > +			compatible = "arm,gic-v3-its";
> > +			msi-controller;
> > +			reg = <0x0 0x6020000 0 0x20000>;
> > +		};
> > +	};
> 
> [...]
> 
> >  	fsl_mc: fsl-mc at 80c000000 {
> >  		compatible = "fsl,qoriq-mc";
> > +		#stream-id-cells = <2>;
> >  		reg = <0x00000008 0x0c000000 0 0x40>,	 /* MC portal base
> */
> >  		      <0x00000000 0x08340000 0 0x40000>; /* MC control reg */
> > +		lpi-parent = <&its>;
> 
> I'm afraid there is no such thing as "lpi_parent" as a property. We have
> msi_parent, which is (I think) what you want, and is dealt with in the
> ITS driver. Also, you'll need to describe the DeviceIDs that can be
> generated by this device so that the ITS can be correctly programmed.
 
Oops. This should be 'msi_parent' as you point out, Marc.

I will address these comments in v3 of the patchset.

Regards,
Bhupesh