[PATCH 2/2] pinctrl: digicolor: convert null test to IS_ERR test

Linus Walleij linus.walleij at linaro.org
Tue Sep 8 01:56:41 PDT 2015


On Mon, Aug 24, 2015 at 11:12 PM, Julia Lawall <Julia.Lawall at lip6.fr> wrote:

> Since commit 323de9efdf3e ("pinctrl: make pinctrl_register() return proper
> error code"), pinctrl_register returns an error code rather than NULL on
> failure.  Update a driver that was introduced more recently.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression e,e1,e2;
> @@
>
> e = pinctrl_register(...)
> ... when != e = e1
> if (
> -   e == NULL
> +   IS_ERR(e)
>    ) {
>      ...
>      return
> -      e2
> +      PTR_ERR(e)
>      ;
>      }
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall at lip6.fr>

Patch applied for fixes.

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list